soc: xtensa/sample_controller: add snippets to linker script #42606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xtensa/sample_controller linker script is missing the necessary include statements for linker snippets. So add them. Fixes zephyrproject-rtos#42477 Signed-off-by: Daniel Leung <[email protected]>
nashif
approved these changes
Feb 10, 2022
andyross
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xtensa/sample_controller linker script is missing the necessary
include statements for linker snippets. So add them.
Fixes #42477
Note that the linker scripts on other Xtensa boards are not updated since they are a bit sensitive to where things are placed. This PR is to unblock #38611 so CI can build and test with
qemu_xtensa. If other Xtensa boards require snippets, they will need to make their own adjustments to their linker scripts.